Updated deps to make testsuite run again #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jankapunkt
added
bug
|
So I updated the CI to only use Node 22 and 24 in order to get this esm/cjs cr💩p somehow running |
There was a problem hiding this comment.
Pull Request Overview
This PR updates development dependencies and converts the project from CommonJS to ES modules to fix the test suite. The main changes include updating Node.js versions, Babel configuration, test runners, and converting module imports/exports throughout the codebase.
- Updated Node.js versions from 16-20 to 22-24 in CI configuration
- Converted all CommonJS
require/module.exportsto ES6import/exportsyntax - Updated development dependencies including Mocha, Babel, and other testing tools
Reviewed Changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dev dependencies and Node.js versions for ESM compatibility |
| test/testHelpers.js | Removed unused Meteor import and test helper, added asyncTimeout utility |
| test/src/*.tests.js | Added .js extensions to all import paths for ESM compatibility |
| src/**/*.js | Added .js extensions to all import paths and converted to ESM |
| lib/*.js | Converted from CommonJS exports to ESM exports |
| helpers/reactNativeBindings.js | Refactored from CommonJS to ESM with cleaner variable declarations |
| test/hooks/mockServer.js | Converted to ESM and improved async handling |
| .github/workflows/node.js.yml | Updated GitHub Actions and Node.js versions |
| README.md | Added migration notice for ESM-only transition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates dev dependencies to get the testsuite running again.
Edit: had to go the full round for esm+cjs cross compatibility
We should soon publish a full esm-only package, it's really annoying.
Linked issue(s)
#168 #167 (this PR is required to fix them)
Involved parts of the project
tests, dev
Added tests?
update mocha runner
Targeted Meteor release version
next release
Reproduction
clone, install, run tests